Develop #860
Open
Develop #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBondarenko1982
suggested changes
Jul 19, 2023
src/components/PostsList.tsx
Outdated
| ? post | ||
| : null)} | ||
| > | ||
| {post.id !== selectedPostId ? 'Open' : 'Close'} |
There was a problem hiding this comment.
Suggested change
| {post.id !== selectedPostId ? 'Open' : 'Close'} | |
| {!isSelected ? 'Open' : 'Close'} |
better to make variable const isSelected = post.id === selectedPostId and use in all places
src/components/NewCommentForm.tsx
Outdated
Comment on lines
18
to
22
| const [value, setValue] = useState({ | ||
| name: '', | ||
| email: '', | ||
| body: '', | ||
| }); |
There was a problem hiding this comment.
make outside component constant with initial values and use in both places.
same for isError state
const initialValue = {
name: '',
email: '',
body: '',
}
Suggested change
| const [value, setValue] = useState({ | |
| name: '', | |
| email: '', | |
| body: '', | |
| }); | |
| const [value, setValue] = useState(initialValue); |
src/components/NewCommentForm.tsx
Outdated
Comment on lines
58
to
62
| setValue({ | ||
| name: '', | ||
| email: '', | ||
| body: '', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| setValue({ | |
| name: '', | |
| email: '', | |
| body: '', | |
| }); | |
| setValue(initialValue); |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
initial commit done