Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posts 1 #884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cypress.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"baseUrl": "http://localhost:3000",
"defaultCommandTimeout": 2000,
"video": true,
"viewportHeight": 1920,
"viewportWidth": 1080,
Expand Down
8 changes: 0 additions & 8 deletions cypress/support/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
import '@mate-academy/cypress-tools/support';

declare global {
namespace Cypress {
interface Chainable<Subject> {
byDataCy(name: string, text: string): Chainable<JQuery>;
}
}
}
18 changes: 0 additions & 18 deletions cypress/support/index.js
Original file line number Diff line number Diff line change
@@ -1,19 +1 @@
require('@mate-academy/cypress-tools/support');

Cypress.Commands.add(
'byDataCy',
{ prevSubject: 'optional' },

(subject, name, text = '') => {
const target = subject || cy;
const selector = `[data-cy="${name}"]`;

if (text) {
return target.contain(selector, text);
}

return subject
? subject.find(selector)
: cy.get(selector);
},
);
43 changes: 24 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,20 @@
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-router-dom": "^6.3.0",
"react-scripts": "^4.0.3"
"react-scripts": "^4.0.3",
"validator": "^13.11.0"
},
"devDependencies": {
"@cypress/webpack-dev-server": "^1.8.4",
"@mate-academy/cypress-tools": "^1.0.5",
"@mate-academy/eslint-config-react-typescript": "^1.0.5",
"@mate-academy/scripts": "^1.2.3",
"@mate-academy/scripts": "^1.2.8",
"@mate-academy/students-ts-config": "*",
"@mate-academy/stylelint-config": "*",
"@types/node": "^17.0.23",
"@types/react": "^17.0.43",
"@types/react-dom": "^17.0.14",
"@types/validator": "^13.11.1",
"cypress": "^9.5.3",
"eslint": "^7.32.0",
"eslint-plugin-cypress": "^2.11.2",
Expand Down
93 changes: 74 additions & 19 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,44 +1,91 @@
import React from 'react';
import React, { useState, useEffect } from 'react';
import 'bulma/bulma.sass';
import '@fortawesome/fontawesome-free/css/all.css';
import './App.scss';

import classNames from 'classnames';
import { PostsList } from './components/PostsList';
import { PostDetails } from './components/PostDetails';
import { UserSelector } from './components/UserSelector';
import { Loader } from './components/Loader';
import { UserSelector } from './components/UserSelector';
import { getUsers } from './utils/api';
import { User } from './types/User';
import { Post } from './types/Post';
import { Comment } from './types/Comment';

export const App: React.FC = () => {
const [users, setUsers] = useState<User[]>([]);
const [selectedUser, setSelectedUser] = useState<User | null>(null);
const [posts, setPosts] = useState<Post[] | null>(null);
const [isLoading, setIsLoading] = useState<boolean>(false);
const [selectedPost, setSelectedPost] = useState<Post | null>(null);
const [comments, setComments] = useState<Comment[] | null>(null);
const [isCommentLoading, setIsCommentLoading] = useState<boolean>(false);
const [postsLoadingError, setPostsLoadingError] = useState<boolean>(false);
const [commentsError, setCommentsError] = useState<boolean>(false);

useEffect(() => {
getUsers('/users')
.then((usersFromAPI) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling API endpoint directly in component. It's better to isolate API calls in separate services or utils.

setUsers(usersFromAPI);
});
}, []);

return (
<main className="section">
<div className="container">
<div className="tile is-ancestor">
<div className="tile is-parent">
<div className="tile is-child box is-success">
<div className="block">
<UserSelector />
<UserSelector
users={users}
selectedUser={selectedUser}
setSelectedUser={setSelectedUser}
setPosts={setPosts}
setIsLoading={setIsLoading}
setPostsLoadingError={setPostsLoadingError}
/>
</div>

<div className="block" data-cy="MainContent">
<p data-cy="NoSelectedUser">
No user selected
</p>
{!selectedUser
&& (
<p data-cy="NoSelectedUser">
No user selected
</p>
)}

<Loader />
{isLoading && <Loader />}

<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
{postsLoadingError
&& (
<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
)}

<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
</div>
{posts && posts.length === 0
&& (
<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
</div>
)}

<PostsList />
{posts && posts.length > 0
&& (
<PostsList
posts={posts !== null ? posts : []}
selectedPost={selectedPost}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary null check. You already checked in the condition above that posts is not null and that its length is greater than 0.

setSelectedPost={setSelectedPost}
setComments={setComments}
setIsCommentLoading={setIsCommentLoading}
setCommentsError={setCommentsError}
/>
)}
</div>
</div>
</div>
Expand All @@ -50,11 +97,19 @@ export const App: React.FC = () => {
'is-parent',
'is-8-desktop',
'Sidebar',
'Sidebar--open',
{ 'Sidebar--open': selectedPost },
)}
>
<div className="tile is-child box is-success ">
<PostDetails />
{selectedPost && (
<PostDetails
selectedPost={selectedPost}
comments={comments}
setComments={setComments}
isCommentLoading={isCommentLoading}
commentsError={commentsError}
/>
)}
</div>
</div>
</div>
Expand Down
Loading
Loading