-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posts 1 #884
Open
vetal-hovenko
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
vetal-hovenko:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
posts 1 #884
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1 @@ | ||
import '@mate-academy/cypress-tools/support'; | ||
|
||
declare global { | ||
namespace Cypress { | ||
interface Chainable<Subject> { | ||
byDataCy(name: string, text: string): Chainable<JQuery>; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1 @@ | ||
require('@mate-academy/cypress-tools/support'); | ||
|
||
Cypress.Commands.add( | ||
'byDataCy', | ||
{ prevSubject: 'optional' }, | ||
|
||
(subject, name, text = '') => { | ||
const target = subject || cy; | ||
const selector = `[data-cy="${name}"]`; | ||
|
||
if (text) { | ||
return target.contain(selector, text); | ||
} | ||
|
||
return subject | ||
? subject.find(selector) | ||
: cy.get(selector); | ||
}, | ||
); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,91 @@ | ||
import React from 'react'; | ||
import React, { useState, useEffect } from 'react'; | ||
import 'bulma/bulma.sass'; | ||
import '@fortawesome/fontawesome-free/css/all.css'; | ||
import './App.scss'; | ||
|
||
import classNames from 'classnames'; | ||
import { PostsList } from './components/PostsList'; | ||
import { PostDetails } from './components/PostDetails'; | ||
import { UserSelector } from './components/UserSelector'; | ||
import { Loader } from './components/Loader'; | ||
import { UserSelector } from './components/UserSelector'; | ||
import { getUsers } from './utils/api'; | ||
import { User } from './types/User'; | ||
import { Post } from './types/Post'; | ||
import { Comment } from './types/Comment'; | ||
|
||
export const App: React.FC = () => { | ||
const [users, setUsers] = useState<User[]>([]); | ||
const [selectedUser, setSelectedUser] = useState<User | null>(null); | ||
const [posts, setPosts] = useState<Post[] | null>(null); | ||
const [isLoading, setIsLoading] = useState<boolean>(false); | ||
const [selectedPost, setSelectedPost] = useState<Post | null>(null); | ||
const [comments, setComments] = useState<Comment[] | null>(null); | ||
const [isCommentLoading, setIsCommentLoading] = useState<boolean>(false); | ||
const [postsLoadingError, setPostsLoadingError] = useState<boolean>(false); | ||
const [commentsError, setCommentsError] = useState<boolean>(false); | ||
|
||
useEffect(() => { | ||
getUsers('/users') | ||
.then((usersFromAPI) => { | ||
setUsers(usersFromAPI); | ||
}); | ||
}, []); | ||
|
||
return ( | ||
<main className="section"> | ||
<div className="container"> | ||
<div className="tile is-ancestor"> | ||
<div className="tile is-parent"> | ||
<div className="tile is-child box is-success"> | ||
<div className="block"> | ||
<UserSelector /> | ||
<UserSelector | ||
users={users} | ||
selectedUser={selectedUser} | ||
setSelectedUser={setSelectedUser} | ||
setPosts={setPosts} | ||
setIsLoading={setIsLoading} | ||
setPostsLoadingError={setPostsLoadingError} | ||
/> | ||
</div> | ||
|
||
<div className="block" data-cy="MainContent"> | ||
<p data-cy="NoSelectedUser"> | ||
No user selected | ||
</p> | ||
{!selectedUser | ||
&& ( | ||
<p data-cy="NoSelectedUser"> | ||
No user selected | ||
</p> | ||
)} | ||
|
||
<Loader /> | ||
{isLoading && <Loader />} | ||
|
||
<div | ||
className="notification is-danger" | ||
data-cy="PostsLoadingError" | ||
> | ||
Something went wrong! | ||
</div> | ||
{postsLoadingError | ||
&& ( | ||
<div | ||
className="notification is-danger" | ||
data-cy="PostsLoadingError" | ||
> | ||
Something went wrong! | ||
</div> | ||
)} | ||
|
||
<div className="notification is-warning" data-cy="NoPostsYet"> | ||
No posts yet | ||
</div> | ||
{posts && posts.length === 0 | ||
&& ( | ||
<div className="notification is-warning" data-cy="NoPostsYet"> | ||
No posts yet | ||
</div> | ||
)} | ||
|
||
<PostsList /> | ||
{posts && posts.length > 0 | ||
&& ( | ||
<PostsList | ||
posts={posts !== null ? posts : []} | ||
selectedPost={selectedPost} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary null check. You already checked in the condition above that posts is not null and that its length is greater than 0. |
||
setSelectedPost={setSelectedPost} | ||
setComments={setComments} | ||
setIsCommentLoading={setIsCommentLoading} | ||
setCommentsError={setCommentsError} | ||
/> | ||
)} | ||
</div> | ||
</div> | ||
</div> | ||
|
@@ -50,11 +97,19 @@ export const App: React.FC = () => { | |
'is-parent', | ||
'is-8-desktop', | ||
'Sidebar', | ||
'Sidebar--open', | ||
{ 'Sidebar--open': selectedPost }, | ||
)} | ||
> | ||
<div className="tile is-child box is-success "> | ||
<PostDetails /> | ||
{selectedPost && ( | ||
<PostDetails | ||
selectedPost={selectedPost} | ||
comments={comments} | ||
setComments={setComments} | ||
isCommentLoading={isCommentLoading} | ||
commentsError={commentsError} | ||
/> | ||
)} | ||
</div> | ||
</div> | ||
</div> | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling API endpoint directly in component. It's better to isolate API calls in separate services or utils.