Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for mentor #892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Mikhaylo-Orlov
Copy link

@Mikhaylo-Orlov Mikhaylo-Orlov commented Aug 13, 2023

Copy link

@Anastasiia-Svintsova Anastasiia-Svintsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the error message if there is no error anymore. And there is no possibility to write a comment if the error has occurred previously. Fix it, please
2023-06-08.130254.mp4


export const UserSelector: React.FC<Props> = ({ users, onUserSelect }) => {
const [isDropdown, setIsDropdown] = useState(false);
const [currentUser, setCurrentUser] = useState('Choose a user');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial value should be null. Then just add a conditional rendering in JSX

Suggested change
const [currentUser, setCurrentUser] = useState('Choose a user');
const [currentUser, setCurrentUser] = useState(null);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants