Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react_dynamic_list-of-posts #904

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

vintwp
Copy link

@vintwp vintwp commented Aug 24, 2023

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Added comments to fix

This comment was marked as resolved.

No posts yet
</div>
*/
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing unused comments

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there) Just one more thing needs to be fixed
i cant enter spaces in comment input at all

@vintwp
Copy link
Author

vintwp commented Aug 25, 2023

Almost there) Just one more thing needs to be fixed i cant enter spaces in comment input at all

Sorry, I didn't check earlier. At now, it's fixed

@vintwp vintwp requested a review from maxim2310 August 25, 2023 08:23
Copy link

@Anastasiia-Svintsova Anastasiia-Svintsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is an issue with the comments displaying. I can see the same comments for each post if there is an error. But if you can't load actual comments you should display just an error message and that's it.
2023-06-08.130254.mp4

src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/NewCommentForm/NewCommentForm.tsx Outdated Show resolved Hide resolved
src/components/NewCommentForm/NewCommentForm.tsx Outdated Show resolved Hide resolved
src/components/PostDetails/PostDetails.tsx Outdated Show resolved Hide resolved
src/components/PostItem/PostItem.tsx Outdated Show resolved Hide resolved
src/components/PostItem/PostItem.tsx Outdated Show resolved Hide resolved
src/components/Sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
src/components/Sidebar/Sidebar.tsx Show resolved Hide resolved
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants