Dynamic list of post #906
Open
Dynamic list of post #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Aug 30, 2023
|
|
||
| type Props = { | ||
| selectedPost: Post; | ||
| setComments: (value: Comment[] | { (prev: Comment[]): Comment[] }) => void, |
| setFormShowed, | ||
| }) => { | ||
| const [comments, setComments] = useState<Comment[]>([]); | ||
| const [isLoading, setLoading] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [isLoading, setLoading] = useState(false); | |
| const [isLoading, setIsLoading] = useState(false); |
| setSelectedUser, | ||
| setSelectedPost, | ||
| }) => { | ||
| const [isActive, setActive] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [isActive, setActive] = useState(false); | |
| const [isActive, setIsActive] = useState(false); |
anastasiia-tilikina
suggested changes
Aug 31, 2023
| @@ -8,7 +8,7 @@ import { addComments } from '../../services/comments'; | |||
|
|
|||
| type Props = { | |||
| selectedPost: Post; | |||
| setComments: (value: Comment[] | { (prev: Comment[]): Comment[] }) => void, | |||
| setComments: (value: Comment[] | ((prev: Comment[]) => Comment[])) => void; | |||
There was a problem hiding this comment.
read provided link once more here the correct answer
There was a problem hiding this comment.
like that?
setComments: React.Dispatch<React.SetStateAction<Comment[]>>;
There was a problem hiding this comment.
like that?
setComments: React.Dispatch<React.SetStateAction<Comment[]>>;
yes, it is more correct type. use in such cases in next tasks
VitaliyBondarenko1982
approved these changes
Aug 31, 2023
| @@ -8,7 +8,7 @@ import { addComments } from '../../services/comments'; | |||
|
|
|||
| type Props = { | |||
| selectedPost: Post; | |||
| setComments: (value: Comment[] | { (prev: Comment[]): Comment[] }) => void, | |||
| setComments: (value: Comment[] | ((prev: Comment[]) => Comment[])) => void; | |||
There was a problem hiding this comment.
like that?
setComments: React.Dispatch<React.SetStateAction<Comment[]>>;
yes, it is more correct type. use in such cases in next tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK