Skip to content

Commit

Permalink
task is done
Browse files Browse the repository at this point in the history
  • Loading branch information
BurchakDmitry committed Oct 14, 2024
1 parent 7d49869 commit 00dc4f5
Show file tree
Hide file tree
Showing 6 changed files with 49 additions and 12 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ Make the `App` a class component with `pressedKey` in the `state`.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_keyboard/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://BurchakDmitry.github.io/react_keyboard/) and add it to the PR description.
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^1.9.12",
"@mate-academy/students-ts-config": "*",
"@mate-academy/stylelint-config": "*",
"@types/node": "^20.14.10",
Expand Down
17 changes: 11 additions & 6 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import React from 'react';
import React, { useState } from 'react';
import { Message } from './components/Message/';

export const App: React.FC = () => (
<div className="App">
<p className="App__message">The last pressed key is [Enter]</p>
</div>
);
export const App: React.FC = () => {
const [message, setMessage] = useState('');

return (
<div className="App">
<Message message={message} setMessage={setMessage} />
</div>
);
};
30 changes: 30 additions & 0 deletions src/components/Message/Message.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { useEffect } from 'react';

interface Props {
message: string;
setMessage: (mes: string) => void;
}

export const Message: React.FC<Props> = ({ message, setMessage }) => {
useEffect(() => {
const handleKeyDown = (event: KeyboardEvent) => {
if (event.key) {
setMessage(event.key);
}
};

window.addEventListener('keydown', handleKeyDown);

return () => {
window.removeEventListener('keydown', handleKeyDown);
};
}, []);

Check warning on line 21 in src/components/Message/Message.tsx

View workflow job for this annotation

GitHub Actions / run_linter (20.x)

React Hook useEffect has a missing dependency: 'setMessage'. Either include it or remove the dependency array. If 'setMessage' changes too often, find the parent component that defines it and wrap that definition in useCallback

return (
<p className="App__message">
{message
? `The last pressed key is [${message}]`
: 'Nothing was pressed yet'}
</p>
);
};
1 change: 1 addition & 0 deletions src/components/Message/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './Message';

0 comments on commit 00dc4f5

Please sign in to comment.