Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added task solution #951

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added task solution #951

wants to merge 3 commits into from

Conversation

vlopatko
Copy link

anstsot
anstsot suggested changes Jul 21, 2023
View reviewed changes
Copy link

@anstsot anstsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s add one fix to improve your code

src/App.tsx
};

componentDidMount(): void {
document.addEventListener('keyup', this.handlePressedKey);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove event listener on unmount

@vlopatko vlopatko requested a review from anstsot July 21, 2023 14:13
And678
And678 approved these changes Jul 24, 2023
View reviewed changes
Copy link

@And678 And678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@And678 And678 And678 approved these changes

@anstsot anstsot Awaiting requested review from anstsot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlopatko @anstsot @And678