Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react_keyboard #971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

react_keyboard #971

wants to merge 2 commits into from

Conversation

zipic
Copy link

@zipic zipic commented Jul 27, 2023

ivbutsykin
ivbutsykin suggested changes Jul 28, 2023
View reviewed changes
Copy link

@ivbutsykin ivbutsykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but you have one critical problem:
image

Please, fix it.

src/App.tsx Outdated
document.addEventListener('keyup', this.handlerEnter);
}

handlerEnter = (event: KeyboardEvent) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
handlerEnter = (event: KeyboardEvent) => {
handlePrint = (event: KeyboardEvent) => {

@zipic zipic requested a review from ivbutsykin July 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleziO OleziO OleziO approved these changes

@ivbutsykin ivbutsykin Awaiting requested review from ivbutsykin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zipic @ivbutsykin @OleziO