Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #1104

wants to merge 1 commit into from

Conversation

lerika7
Copy link

@lerika7 lerika7 commented Oct 13, 2024

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 13, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the code! Just a small tip for the future - when comparing objects, it's better to compare them by their unique identifier. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/components/Tabs/Tabs.jsx
return (
<li
key={tab.id}
className={classNames({ 'is-active': activeTab === tab })}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not compare objects directly. Instead, compare them by their unique identifier. In this case, you should compare tab.id with activeTab.id. This is a common mistake that can lead to unexpected bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lerika7 @mateacademy-ai-mentor