Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #1122

wants to merge 3 commits into from

Conversation

AlenaLoik
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 29, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality. Just a minor tweak is needed: remember to add a key prop to your list items in the Tabs component to ensure optimal rendering in React. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/components/Tabs/Tabs.jsx Outdated
Comment on lines 19 to 20
{tabs.map(tab => (
<li className={tab.id === active && 'is-active'} data-cy="Tab">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The className assignment for the active tab should ensure a string is always returned. Consider using a ternary operator: className={tab.id === active ? 'is-active' : ''} to avoid potential issues with falsy values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor Awaiting requested review from mateacademy-ai-mentor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlenaLoik @mateacademy-ai-mentor