Develop #1480
Open
Develop #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RostyslavSharuiev
commented
Oct 19, 2024
RostyslavSharuiev
commented
- DEMO LINK
EustasTheMonk
suggested changes
Oct 20, 2024
igorkruz
suggested changes
Oct 21, 2024
There was a problem hiding this comment.
Good Job 👍
let's improve your solution
Watch the attached video and fix the setting the completed or active status
https://www.loom.com/share/97916aa3be0542939a584748959138ac?sid=b820ea2a-21eb-4aae-879d-4404a2af64fc
polosanya
approved these changes
Oct 22, 2024
Comment on lines
+87
to
+94
| {tempTodo && ( | ||
| <TodoItem | ||
| todo={tempTodo} | ||
| setIdsForDelete={setIdsForDelete} | ||
| setIdsForUpdate={setIdsForUpdate} | ||
| setNewTodoData={setNewTodoData} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
I guess it can be put inside TodoList component
There was a problem hiding this comment.
Its makes according to part 2 of the todo app
src/components/TodoItem/TodoItem.tsx
Outdated
| /> | ||
| </label> | ||
|
|
||
| {!isEditing ? ( |
There was a problem hiding this comment.
Suggested change
| {!isEditing ? ( | |
| {isEditing ? ( |
It is a good practice to use positive boolean for ternary operator condition, not the objection of it
src/components/TodoItem/TodoItem.tsx
Outdated
| data-cy="TodoLoader" | ||
| className={cn('modal overlay', { | ||
| 'is-active': | ||
| !id || idsForDelete?.includes(id) || idsForUpdate?.includes(id), |
There was a problem hiding this comment.
Would be great to create a variable for it for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.