need help #1485
Open
need help #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 21, 2024
src/components/TodoList.tsx
Outdated
Comment on lines
11
to
12
| // update: (todoToUpdate: Todo) => void; | ||
| // errorFunction: (message: string) => void; |
src/components/TodoHeader.tsx
Outdated
| className={classNames('todoapp__toggle-all', { | ||
| active: checkActiveTodos(), | ||
| })} | ||
| onClick={() => handleToggleAll()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => handleToggleAll()} | |
| onClick={handleToggleAll} |
src/api/todos.ts
Outdated
Comment on lines
10
to
16
| export const getActiveTodos = () => { | ||
| return getTodos().then(todos => todos.filter(todo => !todo.completed)); | ||
| }; | ||
|
|
||
| export const getCompletedTodos = () => { | ||
| return getTodos().then(todos => todos.filter(todo => todo.completed)); | ||
| }; |
There was a problem hiding this comment.
you don't need to make separate requests for active or completed todos, just filter the todos state in the component
src/api/todos.ts
Outdated
| }; | ||
|
|
||
| export const createTodo = ({ userId, title, completed }: Omit<Todo, 'id'>) => { | ||
| return client.post<Todo>(`/todos`, { userId, title, completed }); |
There was a problem hiding this comment.
Suggested change
| return client.post<Todo>(`/todos`, { userId, title, completed }); | |
| return client.post<Todo>('/todos', { userId, title, completed }); |
anastasiiavorobiova
suggested changes
Oct 22, 2024
etojeDenys
suggested changes
Oct 22, 2024
There was a problem hiding this comment.
fix this case(you should delete the todo in this case, but you try to update it)
https://github.com/user-attachments/assets/892759a6-7a65-4885-b19a-64ccd16e8f44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://Shevchuchka.github.io/react_todo-app-with-api/