Develop #1491
Develop #1491
Conversation
There was a problem hiding this comment.
Good Job 👍
let's improve your solution
Review the attached video and fix the bug.
https://www.loom.com/share/ddbab52f666943d7a3fc6aa58c05105f
src/App.tsx
Outdated
| todoFromService | ||
| .getTodos() | ||
| .then(setTodos) | ||
| .catch(() => setErrorMessage(TypeError.LOADING)); |
There was a problem hiding this comment.
It's better to move the logic inside the useEffect hook to a separate function, as it improves code readability, reusability, and makes testing easier. It also helps keep useEffect focused on side effects.
src/components/Error/Error.tsx
Outdated
| setErrorMessage: React.Dispatch<React.SetStateAction<TypeError>>; | ||
| }; | ||
|
|
||
| export const Error: React.FC<Props> = ({ errorMessage, setErrorMessage }) => { |
There was a problem hiding this comment.
| export const Error: React.FC<Props> = ({ errorMessage, setErrorMessage }) => { | |
| export const Error: FC<Props> = ({ errorMessage, setErrorMessage }) => { |
| type="button" | ||
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| disabled={completedTodos.length === 0} |
There was a problem hiding this comment.
| disabled={completedTodos.length === 0} | |
| disabled={!completedTodos.length} |
| todoFromService | ||
| .getTodos() | ||
| .then(setTodos) | ||
| .catch(() => setErrorMessage(TypeError.LOADING)); |
There was a problem hiding this comment.
It's better to move the logic inside the useEffect hook to a separate function, as it improves code readability, reusability, and makes testing easier. It also helps keep useEffect focused on side effects.
DEMO LINK