Todo app #1495
Open
Todo app #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Oct 23, 2024
volodymyr-soltys97
suggested changes
Oct 25, 2024
src/App.tsx
Outdated
Comment on lines
54
to
60
| case 'All': | ||
| visibleTodos = todos; | ||
| break; | ||
| case 'Active': | ||
| visibleTodos = todos.filter(todo => !todo.completed); | ||
| break; | ||
| case 'Completed': |
There was a problem hiding this comment.
Create a enum for 'All', 'Active', 'Completed' and use it everywhere
src/App.tsx
Outdated
Comment on lines
95
to
98
| //#endregion | ||
|
|
||
| //#region add Todos | ||
| // input |
There was a problem hiding this comment.
Remove all comments, it's redundant here
src/App.tsx
Outdated
| titleRef={titleRef} | ||
| /> | ||
|
|
||
| {todos.length !== 0 && ( |
There was a problem hiding this comment.
Suggested change
| {todos.length !== 0 && ( | |
| {!!todos.length && ( |
src/components/Footer/Footer.tsx
Outdated
| return ( | ||
| <footer className="footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {todos.filter(todo => !todo.completed).length} items left |
There was a problem hiding this comment.
Move this logic to the helper variable and use it here
src/components/Footer/Footer.tsx
Outdated
Comment on lines
32
to
63
| <a | ||
| href="#/" | ||
| className={cn('filter__link', { | ||
| selected: selectedFilter === 'All', | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={onFilterAll} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={cn('filter__link', { | ||
| selected: selectedFilter === 'Active', | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={onFilterActive} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={cn('filter__link', { | ||
| selected: selectedFilter === 'Completed', | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={onFilterCompleted} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
Use Object.values(your created enum) and render these options with map() method
src/components/Header/Header.tsx
Outdated
| }) => { | ||
| return ( | ||
| <header className="header"> | ||
| {todos.length !== 0 && ( |
There was a problem hiding this comment.
Suggested change
| {todos.length !== 0 && ( | |
| {!!todos.length && ( |
src/components/Header/Header.tsx
Outdated
| active: todos.every(todo => todo.completed), | ||
| })} | ||
| data-cy="ToggleAllButton" | ||
| onClick={() => onToggleAll()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => onToggleAll()} | |
| onClick={onToggleAll} |
src/components/TodoItem/TodoItem.tsx
Outdated
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| checked={todo.completed} |
etojeDenys
suggested changes
Oct 25, 2024
volodymyr-soltys97
approved these changes
Oct 25, 2024
| //#endregion | ||
|
|
||
| //#region rename Todo | ||
| const [redactingQuery, setRedactingQuery] = useState(selectedTodo?.title); |
There was a problem hiding this comment.
All states must be declared at the beginning of the component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK