develop #1496
Open
develop #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hma-3
approved these changes
Oct 23, 2024
src/components/TodoHeader.tsx
Outdated
Comment on lines
74
to
79
| // todos.forEach(todo => | ||
| // onUpdate({ | ||
| // ...todo, | ||
| // completed: isAllCompleted ? false : true, | ||
| // }), | ||
| // ); |
|
|
||
| const handleUpdate = () => { | ||
| if (!newTitle) { | ||
| setIsEditing(true); |
There was a problem hiding this comment.
Edit Form
if title became empty
should stay open on fail:
| return; | ||
| } | ||
|
|
||
| if (newTitle.trim() === todo.title) { |
There was a problem hiding this comment.
you can create a variable for newTitle.trim() since you use it more than once
src/components/TodoItem.tsx
Outdated
| const [isEditing, setIsEditing] = useState(false); | ||
| const [newTitle, setNewTitle] = useState(todo.title); | ||
| const [isUpdating, setIsUpdating] = useState(false); | ||
| const [isChecked, setIsChecked] = useState(todo.completed); |
There was a problem hiding this comment.
why do you need the isChecked state? I haven't seen that you use it
There was a problem hiding this comment.
Why do you need the isChecked state? You can use todo.completed
igorkruz
suggested changes
Oct 28, 2024
src/components/TodoFooter.tsx
Outdated
| return ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {`${activeTodosCount} items left`} |
There was a problem hiding this comment.
Suggested change
| {`${activeTodosCount} items left`} | |
| {activeTodosCount} items left |
| completedTodosIds: number[]; | ||
| } | ||
|
|
||
| export const TodoFooter: React.FC<Props> = ({ |
There was a problem hiding this comment.
Suggested change
| export const TodoFooter: React.FC<Props> = ({ | |
| export const TodoFooter: FC<Props> = ({ |
src/components/TodoHeader.tsx
Outdated
Comment on lines
74
to
79
| // todos.forEach(todo => | ||
| // onUpdate({ | ||
| // ...todo, | ||
| // completed: isAllCompleted ? false : true, | ||
| // }), | ||
| // ); |
src/components/TodoItem.tsx
Outdated
| const [isEditing, setIsEditing] = useState(false); | ||
| const [newTitle, setNewTitle] = useState(todo.title); | ||
| const [isUpdating, setIsUpdating] = useState(false); | ||
| const [isChecked, setIsChecked] = useState(todo.completed); |
There was a problem hiding this comment.
Why do you need the isChecked state? You can use todo.completed
|
|
||
| const handleUpdate = () => { | ||
| if (!newTitle) { | ||
| setIsEditing(true); |
| return; | ||
| } | ||
|
|
||
| if (newTitle.trim() === todo.title) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://Ostkreuzzz.github.io/react_todo-app-with-api/