TAsk was solved #1502
Open
TAsk was solved #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NazariiAlieksieiev
commented
Oct 25, 2024
NazariiAlieksieiev
commented
- DEMO
etojeDenys
suggested changes
Oct 25, 2024
src/App.tsx
Outdated
Comment on lines
412
to
445
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {todosCounter} | ||
| </span> | ||
|
|
||
| <nav className="filter" data-cy="Filter" onClick={onSetStatus}> | ||
| <a | ||
| href="#/" | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.all), | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href={`#/${Status.active}`} | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.active), | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href={`#/${Status.completed}`} | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.completed), | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| > | ||
| Completed |
There was a problem hiding this comment.
create the footer and header components, it will simplify the logic
volodymyr-soltys97
suggested changes
Oct 26, 2024
Comment on lines
47
to
75
| <a | ||
| href="#/" | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.all), | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href={`#/${Status.active}`} | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.active), | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href={`#/${Status.completed}`} | ||
| className={cn('filter__link', { | ||
| selected: isActiveButton(Status.completed), | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
Use Object.values(your created enum) and render these options with map() method
|
|
||
| return ( | ||
| <section className="todoapp__main" data-cy="TodoList"> | ||
| {todos.map((todo, i) => ( |
There was a problem hiding this comment.
Do you need index here
Suggested change
| {todos.map((todo, i) => ( | |
| {todos.map((todo) => ( |
src/components/TodoList/TodoList.tsx
Outdated
| className="todo__title" | ||
| onDoubleClick={() => onStartEditing(todo.title, todo.id)} | ||
| > | ||
| {todo.title} |
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
51
to
64
| <div | ||
| data-cy="Todo" | ||
| className={cn('todo', { completed: todo.completed })} | ||
| key={todo.id} | ||
| > | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| data-todoId={todo.id} | ||
| type="checkbox" | ||
| className="todo__status" | ||
| checked={todo.completed} | ||
| onClick={() => onToggle(todo.id, i)} | ||
| /> |
There was a problem hiding this comment.
Move all these logic to the TodoItem component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.