Skip to content

Commit

Permalink
chore: remove un-actionable todos from labs
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 594112463
  • Loading branch information
asyncLiz authored and copybara-github committed Dec 27, 2023
1 parent 9973b90 commit 363fc05
Show file tree
Hide file tree
Showing 12 changed files with 13 additions and 20 deletions.
2 changes: 1 addition & 1 deletion labs/badge/internal/badge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {property} from 'lit/decorators.js';
import {classMap} from 'lit/directives/class-map.js';

/**
* TODO(b/265340196): add docs
* b/265340196 - add docs
*/
export class Badge extends LitElement {
@property() value = '';
Expand Down
2 changes: 1 addition & 1 deletion labs/navigationbar/internal/navigation-bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {NavigationTabInteractionEvent} from './constants.js';
import {NavigationBarState} from './state.js';

/**
* TODO(b/265346501): add docs
* b/265346501 - add docs
*
* @fires navigation-bar-activated {CustomEvent<tab: NavigationTab, activeIndex: number>}
* Dispatched whenever the `activeIndex` changes. --bubbles --composed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $_reference: (
'container-height': 100%,
'container-shape': 0 16px 16px 0,
'container-width': 360px,
// TODO(b/216384393): Temporary existing token to use for shadow color
// b/216384393 - Temporary existing token to use for shadow color
'divider-color': #000,
'modal-container-elevation': 1,
'scrim-color': null,
Expand Down
2 changes: 1 addition & 1 deletion labs/navigationdrawer/internal/_navigation-drawer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $_reference: (
'container-height': 100%,
'container-shape': 0 16px 16px 0,
'container-width': 360px,
// TODO(b/216384393): Temporary existing token to use for shadow color
// b/216384393 - Temporary existing token to use for shadow color
'divider-color': #000,
'modal-container-elevation': 1,
'standard-container-elevation': 0,
Expand Down
2 changes: 1 addition & 1 deletion labs/navigationdrawer/internal/navigation-drawer-modal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js';
import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';

/**
* TODO(b/265346501): add docs
* b/265346501 - add docs
*
* @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>}
* Dispatched whenever the drawer opens or closes --bubbles --composed
Expand Down
2 changes: 1 addition & 1 deletion labs/navigationdrawer/internal/navigation-drawer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js';
import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';

/**
* TODO(b/265346501): add docs
* b/265346501 - add docs
*
* @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>}
* Dispatched whenever the drawer opens or closes --bubbles --composed
Expand Down
4 changes: 2 additions & 2 deletions labs/navigationtab/internal/navigation-tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js';
import {NavigationTabState} from './state.js';

/**
* TODO(b/265346501): add docs
* b/265346501 - add docs
*
* @fires navigation-tab-rendered {Event} Dispatched when the navigation tab's
* DOM has rendered and custom element definition has loaded. --bubbles
Expand Down Expand Up @@ -117,7 +117,7 @@ export class NavigationTab extends LitElement implements NavigationTabState {
}

handleClick() {
// TODO(b/269772145): connect to ripple
// b/269772145 - connect to ripple
this.dispatchEvent(
new CustomEvent('navigation-tab-interaction', {
detail: {state: this},
Expand Down
7 changes: 0 additions & 7 deletions labs/navigationtab/internal/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,4 @@ export interface NavigationTabState {
* If true, when inactive label will be hidden.
*/
hideInactiveLabel: boolean;

/**
* Inner button for the tab
* TODO(b/229015424): Remove this when the jscompiler rename issue is
* understood.
*/
buttonElement: HTMLElement | null;
}
4 changes: 2 additions & 2 deletions labs/segmentedbutton/internal/_outlined-segmented-button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

@mixin styles() {
$tokens: tokens.md-comp-outlined-segmented-button-values();
// TODO(b/198759625): Remove spacing tokens once provided.
// b/198759625 - Remove spacing tokens once provided.
$tokens: map.merge(
$tokens,
(
Expand All @@ -33,7 +33,7 @@
.md3-segmented-button__outline {
border-radius: inherit;
border-style: solid;
// TODO(b/233762888): Move border-width and inset into theme after generating latest version of tokens.
// Move border-width and inset into theme.
border-width: 1px;
inset: 0px -0.5px;
pointer-events: none;
Expand Down
2 changes: 1 addition & 1 deletion labs/segmentedbutton/internal/_shared.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
&.md3-segmented-button--selected.md3-segmented-button--with-label.md3-segmented-button--with-checkmark,
&.md3-segmented-button--selected.md3-segmented-button--without-label.md3-segmented-button--with-checkmark {
.md3-segmented-button__graphic {
// TODO(b/198759625): Use padding token instead of hardcoded 8px value.
// b/198759625 - Use padding token instead of hardcoded 8px value.
width: calc(var(--_icon-size) + 8px);
}
}
Expand Down
2 changes: 1 addition & 1 deletion labs/segmentedbutton/internal/outlined-segmented-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {html} from 'lit';
import {SegmentedButton} from './segmented-button.js';

/**
* TODO(b/265346443): add docs
* b/265346443 - add docs
*/
export class OutlinedSegmentedButton extends SegmentedButton {
protected override getRenderClasses() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import {SegmentedButtonSet} from './segmented-button-set.js';

/**
* TODO(b/265346443): add docs
* b/265346443 - add docs
*/
export class OutlinedSegmentedButtonSet extends SegmentedButtonSet {
protected override getRenderClasses() {
Expand Down

0 comments on commit 363fc05

Please sign in to comment.