Merge pull request #5752 from vdegenne:icon-button-href

PiperOrigin-RevId: 702387438
material-components · Dec 3, 2024 · 735b3cc · 735b3cc
2 parents 045fe94 + ea1134a
commit 735b3cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/iconbutton/internal/_shared.scss b/iconbutton/internal/_shared.scss
@@ -92,8 +92,10 @@
   }
 
   .link {
+    display: grid;
     height: 100%;
     outline: none;
+    place-items: center;
     position: absolute;
     width: 100%;
   }

diff --git a/iconbutton/internal/icon-button.ts b/iconbutton/internal/icon-button.ts
@@ -179,8 +179,7 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
         ${this.renderRipple()}
         ${!this.selected ? this.renderIcon() : nothing}
         ${this.selected ? this.renderSelectedIcon() : nothing}
-        ${this.renderTouchTarget()}
-        ${this.href && this.renderLink()}
+        ${this.href ? this.renderLink() : this.renderTouchTarget()}
   </${tag}>`;
   }
 
@@ -193,7 +192,9 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
         id="link"
         href="${this.href}"
         target="${this.target || nothing}"
-        aria-label="${ariaLabel || nothing}"></a>
+        aria-label="${ariaLabel || nothing}">
+        ${this.renderTouchTarget()}
+      </a>
     `;
   }