Skip to content

fix(all): add chip-set to all.js file #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

vdegenne
Copy link
Contributor

This PR will add chip-set element to the list in all.js.

Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add it to common.js as well?

@vdegenne vdegenne requested a review from asyncLiz October 24, 2023 18:43
@asyncLiz asyncLiz changed the title chore(all): add chip-set to all.js file fix(all): add chip-set to all.js file Oct 24, 2023
@AndrewJakubowicz
Copy link
Collaborator

Thank you! Quick nit: internally lint is failing because those imports need to be in alphabetical order.

So chip-set needs to be moved down one line between assist-chip and filter-chip.

@vdegenne
Copy link
Contributor Author

Thank you! Quick nit: internally lint is failing because those imports need to be in alphabetical order.

So chip-set needs to be moved down one line between assist-chip and filter-chip.

I knew there were something with these lint comments 😹
I've updated.

@copybara-service copybara-service bot merged commit d09bdc4 into material-components:main Oct 25, 2023
@vdegenne vdegenne deleted the all-chip-set branch October 26, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants