Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): add testing folder to npm package #5399

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Christian24
Copy link
Contributor

This should fix #5397.

@asyncLiz asyncLiz changed the title Add testing folder to npm package fix(testing): add testing folder to npm package Jan 19, 2024
@asyncLiz asyncLiz self-assigned this Jan 19, 2024
Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to double check the package contents before importing

Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change first!

package.json Show resolved Hide resolved
@Christian24 Christian24 requested a review from asyncLiz January 19, 2024 22:26
package.json Outdated Show resolved Hide resolved
@Christian24 Christian24 requested a review from asyncLiz January 19, 2024 22:40
@Christian24
Copy link
Contributor Author

I reworded the commit message so hopefully it passes listing.

@asyncLiz
Copy link
Collaborator

I reworded the commit message so hopefully it passes listing.

aggressively stamps each import email change 😂

No worries, it'll use the pr title when merging. Sometimes the check gets stale :)

@Christian24
Copy link
Contributor Author

It seems it is still not happy with the PR title...

@asyncLiz
Copy link
Collaborator

It seems it is still not happy with the PR title...

Nw, it'll get all fixed later! Just waiting on Elliott to stamp it internally and the bot will do the rest :P

@asyncLiz
Copy link
Collaborator

It seems it is still not happy with the PR title...

Nw, it'll get all fixed later! Just waiting on Elliott to stamp it internally and the bot will do the rest :P

Ohhhh wait it's a type that it doesn't know about. Lemme fix that.

@asyncLiz
Copy link
Collaborator

It should be good to go after #5410

@copybara-service copybara-service bot merged commit a3b2be8 into material-components:main Jan 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add harness to npm package
2 participants