fix(textfield): browser autocomplete works outside of a form #5617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
asyncLiz
requested changes
May 15, 2024
textfield/internal/text-field.ts
Outdated
| @@ -604,6 +609,7 @@ export abstract class TextField extends textFieldBaseClass { | |||
| aria-invalid=${this.hasError} | |||
| aria-label=${ariaLabel} | |||
| autocomplete=${autocomplete || nothing} | |||
| name=${this.name} | |||
There was a problem hiding this comment.
Can you add || nothing to not render the name attribute when none is provided?
name=${this.name || nothing}
There was a problem hiding this comment.
Thanks for the comments. PR updated as advised.
asyncLiz
changed the title
engrbm87
force-pushed
the
forward-name-to-input
branch
from
4b59ef6 to
ba5201b
Compare
copybara-service
bot
merged commit 0502b47
into
material-components:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add name attribute to input and textarea elements created by the text-filed element.
This enables autocomplete to work int he browser even if a form is not used.
Discussed in issue #4589