Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): clipboard check copy icon not showing #5697

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix(catalog): clipboard check copy icon not showing #5697

merged 2 commits into from
Aug 16, 2024

Conversation

yashrajbharti
Copy link
Contributor

@yashrajbharti yashrajbharti commented Aug 16, 2024

Fixes #5696

Description:

This pull request addresses issue #5696, where the check mark indicating a successful clipboard action did not appear when clicking the clipboard icon in the Material Web UI.

Changes Made:

  • Updated the icon name from checkmark to check in the slot="selected" for the md-icon-button component.

Details:

The issue occurred because the md-icon component was using an incorrect icon name for the selected state. By changing the icon name to check, the check mark now correctly displays upon clicking the clipboard icon, providing the expected visual feedback.

Testing:

  • Verified that the check mark appears correctly after clicking the clipboard icon.
  • Ensured that no other functionalities were affected by this change.

Related Issue:

@asyncLiz asyncLiz changed the title Clipboard Checked Status for md-icon fix(catalog): clipboard check copy icon not showing Aug 16, 2024
Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@copybara-service copybara-service bot merged commit be69438 into material-components:main Aug 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard checked status for md-icon doesn't show up
2 participants