Skip to content

fix(iconbutton): override and delegate click #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(iconbutton): override and delegate click #5843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45150fa
fix(iconbutton): override and delegate click
vdegenne Aug 28, 2025
2b6c59b
unecessary ?
vdegenne Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions iconbutton/internal/icon-button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import '../../focus/md-focus-ring.js';
import '../../ripple/ripple.js';

import {html, isServer, LitElement, nothing} from 'lit';
import {property, state} from 'lit/decorators.js';
import {html, LitElement, nothing} from 'lit';
import {property, query, state} from 'lit/decorators.js';
import {classMap} from 'lit/directives/class-map.js';
import {literal, html as staticHtml} from 'lit/static-html.js';

Expand Down Expand Up @@ -144,10 +144,11 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {

@state() private flipIcon = isRtl(this, this.flipIconInRtl);

constructor() {
super();
if (!isServer) {
this.addEventListener('click', this.handleClick.bind(this));
@query('.button') private readonly buttonElement!: HTMLElement | null;

override click() {
if (!this.disabled && this.buttonElement) {
this.buttonElement.click();
}
}

Expand Down Expand Up @@ -195,7 +196,7 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
const {ariaLabel} = this as ARIAMixinStrict;
return html`
<a
class="link"
class="link button"
id="link"
href="${this.href}"
download="${this.download || nothing}"
Expand All @@ -210,6 +211,7 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
return {
'flip-icon': this.flipIcon,
'selected': this.toggle && this.selected,
'button': !this.href
};
}

Expand Down Expand Up @@ -248,18 +250,6 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
super.connectedCallback();
}

/** Handles a click on this element. */
private handleClick(event: MouseEvent) {
// If the icon button is soft-disabled, we need to explicitly prevent the
// click from propagating to other event listeners as well as prevent the
// default action.
if (!this.href && this.softDisabled) {
event.stopImmediatePropagation();
event.preventDefault();
return;
}
}

/**
* Handles a click on the child <div> or <button> element within this
* element's shadow DOM.
Expand Down