Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materials Cloud implementation: index metadatabase & other updates #26

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

eimrek
Copy link
Member

@eimrek eimrek commented Sep 6, 2023

Added

  • Optimade index meta-database
  • Saving the metadata of each entry in the mongodb
  • Using the metadata in the index and the landing page.

Running at https://dev-optimade.materialscloud.org/

Additonally, an important point:

I separated data injection and starting of the containers. The reasoning is the following:

The initial two steps:

  1. download from archive;
  2. conversion to jsonl;

are just needed for setting up the MongoDB. If the mongodb is there, these two steps are not needed. Therefore, it makes sense to have this be indepedent from running the docker containers. This makes stopping and re-running the containers (e.g. if i want to test a new docker image) more convenient, if data injection is decoupled. Possibly, i would even suggest to move the data_inject function from optimade-launch to mc_optimade.

Pinging @ml-evs @unkcpz, just to be aware of the last point.

@eimrek
Copy link
Member Author

eimrek commented Sep 6, 2023

These changes shouldn't conflict with other parts so I'll just merge

@eimrek eimrek merged commit fbae4d9 into main Sep 6, 2023
1 check passed
@eimrek eimrek deleted the mcloud-improvements branch September 6, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant