Materials Cloud implementation: index metadatabase & other updates #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Running at https://dev-optimade.materialscloud.org/
Additonally, an important point:
I separated data injection and starting of the containers. The reasoning is the following:
The initial two steps:
are just needed for setting up the MongoDB. If the mongodb is there, these two steps are not needed. Therefore, it makes sense to have this be indepedent from running the docker containers. This makes stopping and re-running the containers (e.g. if i want to test a new docker image) more convenient, if data injection is decoupled. Possibly, i would even suggest to move the
data_inject
function fromoptimade-launch
tomc_optimade
.Pinging @ml-evs @unkcpz, just to be aware of the last point.