Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure repository around 'optimake' package #46

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Jan 15, 2024

This PR refactors the repository to focus on the newly named optimake Python package. For now I've retained optimade_launch as another package in the src directory, but have left it unlisted in the pyproject.toml. None of the code usage should change except changing imports from mc_optimade to optimake.

@ml-evs ml-evs requested a review from eimrek January 15, 2024 22:18
@eimrek
Copy link
Member

eimrek commented Jan 16, 2024

awesome, thanks, i'll take a detailed look later today. However, just to quickly mention, the only thing that i'm currently using from optimade-launch is the data injection to mongoDB (https://github.com/materialscloud-org/optimade-maker/blob/main/src/optimade_launch/optimade_launch/database.py). I am wondering if this is maybe of more general interest and should also be moved to optimake? Or would it be better to move this to the MC-implementation-specific repository?

@ml-evs
Copy link
Collaborator Author

ml-evs commented Jan 16, 2024

awesome, thanks, i'll take a detailed look later today. However, just to quickly mention, the only thing that i'm currently using from optimade-launch is the data injection to mongoDB (https://github.com/materialscloud-org/optimade-maker/blob/main/src/optimade_launch/optimade_launch/database.py). I am wondering if this is maybe of more general interest and should also be moved to optimake? Or would it be better to move this to the MC-implementation-specific repository?

Yeah, I was thinking of moving this too. Then we can have optimake serve and optimake validate (#45) based on it + mongomock. Perhaps we could merge this first and then I'll follow-up with a new PR + tests?

Copy link
Member

@eimrek eimrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eimrek eimrek merged commit 94073ac into main Jan 16, 2024
1 check passed
@eimrek eimrek deleted the ml-evs/refactor branch January 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants