Loosen numpy and pandas deps #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eimrek, could we get this merged please? I'll have another PR building on this that requires these deps to be more easily installable alongside other packages |
|
@ml-evs Sorry! yep, everything looks good. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eimrek, I am trying to use
optimakeas part of another project, which unfortunately requires me to use an older library that only supports pandas v1. As we only use pandas forread_csv, I think we can safely allow pandas?The same is true for numpy, we only use it (explicitly) during testing, so we should free up the deps that might need v2 and see how it falls out.
I'm happy to add testing of minimum supported versions (via
uv) if that would be useful too.