Skip to content

Conversation

esoteric-ephemera
Copy link
Collaborator

Changes related to the coming emmet-core==0.85.0 release:

  • Compatibility with AlphaID and the new SuffixedID classes in thermo, insertion electrodes, and XAS
  • Using emmet-core's ID validation to handle checking of user-input identifiers (across MPID, AlphaID, SuffixedID)
  • Removed api_sanitize so that loading MPRester() does not change the underlying emmet models (the previous behavior)
  • Modified MPDataDoc construction to not inherit directly from the emmet model (would require modifying them in place to make required fields optional) but to inherit the typing / validation options from them

@esoteric-ephemera
Copy link
Collaborator Author

esoteric-ephemera commented Oct 1, 2025

@tschaume tests also appear to be passing with emmet-core==0.85.0: https://github.com/esoteric-ephemera/mp_api/actions/runs/18168803758/job/51718058361

Good to see overall, would recommend merging #996 first to ensure the maggma deps are removed, then this PR

@esoteric-ephemera esoteric-ephemera changed the title [WIP] Compatibility with emmet 0.85.0 Compatibility with emmet 0.85.0 Oct 1, 2025
@esoteric-ephemera
Copy link
Collaborator Author

@tschaume and @tsmathis: implemented some simple version guards for changes in import strings in emmet using mp_api.client.core.utils._compare_emmet_ver. Let me know if those look reasonable to you / if you want changes

@tsmathis
Copy link
Collaborator

tsmathis commented Oct 3, 2025

... implemented some simple version guards for changes in import strings in emmet using mp_api.client.core.utils._compare_emmet_ver. Let me know if those look reasonable to you / if you want changes

Looks good, should help going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants