Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bump monty #1095

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

naik-aakash
Copy link
Contributor

Changes

Upgrade monty to latest version

Reason

See materialsproject/pymatgen#4243, due to accidental oversight with deprecation warning raise behaviour in monty, all downstream packages where an earlier version of monty is used, CI tests fails

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.13%. Comparing base (4244da9) to head (6bf394e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1095       +/-   ##
==========================================
- Coverage   72.82%   4.13%   -68.69%     
==========================================
  Files         187     187               
  Lines       13637   13627       -10     
  Branches     1370    1372        +2     
==========================================
- Hits         9931     564     -9367     
- Misses       3161   13032     +9871     
+ Partials      545      31      -514     

see 167 files with indirect coverage changes

@JaGeo
Copy link
Member

JaGeo commented Jan 4, 2025

Thanks @naik-aakash . But there seems to be another issue now 😬

@naik-aakash
Copy link
Contributor Author

Thanks @naik-aakash . But there seems to be another issue now 😬

Yeah Abinit parsers need to be updated in pymatgen seems 😅

@naik-aakash
Copy link
Contributor Author

Thanks @naik-aakash . But there seems to be another issue now 😬

Yeah Abinit parsers need to be updated in pymatgen seems 😅

Correction : Just a new release of pymatgen should be enough. Parsers in pymatgen are already updated

@DanielYang59
Copy link

Correction : Just a new release of pymatgen should be enough. Parsers in pymatgen are already updated

Yep I believe this has been fixed by materialsproject/pymatgen#4223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants