Add a CI run that only tests non-optional deps (optimistically) #3759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #3646.
This PR adds a separate test suite run for the case that only mandatory dependencies have been installed (directly via
pip install -e .[dev]
), attempting to mimic what a user will actually have when they justpip install pymatgen
. This will then hopefully catch errors where either optional imports are not properly guarded, or main functionality is rendered broken by optional dependency updates.Not sure if this is something that you would actually want to merge given the potential maintenance overhead, but this might be able to spot more issues before they arise now that #3757 is merged.
Someone will need to carefully look at how I am invoking the tests, as I'm not sure if there is any coverage/durations magic going on that needs to be separated between the two runs (the comments to that effect at the top of
test.yml
might now be out of date).