-
Notifications
You must be signed in to change notification settings - Fork 907
Replace hard coded class names, add types for io.vasp.sets
#3863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
janosh
merged 30 commits into
materialsproject:master
from
DanielYang59:replace-hard-coded-class-names
Jun 7, 2024
Merged
Replace hard coded class names, add types for io.vasp.sets
#3863
janosh
merged 30 commits into
materialsproject:master
from
DanielYang59:replace-hard-coded-class-names
Jun 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
commented
Jun 5, 2024
DanielYang59
commented
Jun 5, 2024
DanielYang59
commented
Jun 6, 2024
DanielYang59
commented
Jun 6, 2024
DanielYang59
commented
Jun 6, 2024
DanielYang59
commented
Jun 7, 2024
@janosh Ready for review now, thanks for your time :) |
This reverts commit ec8da35.
janosh
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @DanielYang59! nice work! 👍
Thanks for reviewing, and I really appreciate your merging this before splitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
io.vasp.sets
and comment tweaksdeadline
indeprecated
decorator for easier tracking of deprecated functions