-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounting for FHI-aims species' defaults #3877
Conversation
Would it be possible to reintroduce the default |
otherwise this looks good from an fhi-aims perspective. This will break atomate2 tests but we can fix that once it is merged |
Yeah, it could be possible (just remove one check and add |
Okay that makes sense |
Hi, is there anything that should be done here? |
@ansobolev Thanks for contributing in any case! I alao hope one of the maintainers will soon have some time! 😃 |
Thanks for the contribution. I have merged it! |
Summary
This PR adds new SpeciesDefaults object to account for files with the default definitions of species-related keywords (integration grids, basis sets...) in FHI-aims, named species' defaults. This is done to abstract away the work with species' defaults from the
AimsControlIn
object, to bring the API more in line with VASP, and to enable running heterogeneous calculations that need different precision levels for different atoms.Major changes:
AimsSpeciesFile
class representing the defaults for one species is introducedSpeciesDefaults
class representing a list of species' defaults is introduced; theAimsControlIn
class now usesSpeciesDefault
AIMS_SPECIES_DIR
configuration variable is introduced which should point to the root ofFHIaims/species_defaults
directoryFHIaims/species_defaults
orFHIaims/species_defaults/defaults_2020
.Todos
None
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)