Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to LOBSTER >=5.0 #4065

Merged
merged 39 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
083e696
added new LOBSTER 5.0/5.1 keywords
naik-aakash Sep 13, 2024
b0ee42e
update grosspop parser
naik-aakash Sep 15, 2024
33b64b7
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Sep 15, 2024
f940a5c
remove redundant condition check
naik-aakash Sep 15, 2024
3946068
add POLARIZATION.lobster parser
naik-aakash Sep 15, 2024
3966889
update icohplist parser
naik-aakash Sep 15, 2024
39f6fb5
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Sep 16, 2024
9d97565
update lobsterout parser
naik-aakash Sep 16, 2024
f08cdbc
update lobsterout test
naik-aakash Sep 16, 2024
191f7e1
Merge branch 'master' into lobster_parsers_update
JaGeo Sep 25, 2024
f42ff4d
add parser to read BWDF.lobster files
naik-aakash Sep 27, 2024
19e3f69
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Sep 27, 2024
4648e31
minor doc-string improvement
naik-aakash Sep 27, 2024
aa443e4
adapt icohplist, cohpcar parsers to work with *.LCFO.lobster files
naik-aakash Sep 29, 2024
e8fbc5e
make doscar partially work with doscar.lcfo.lobster files (LobsterCom…
naik-aakash Sep 30, 2024
418305e
add todo comment
naik-aakash Sep 30, 2024
557f291
add todo comment
naik-aakash Sep 30, 2024
935aaa7
minor improvment in doscar parser
naik-aakash Sep 30, 2024
16aa12c
bypass LobsterCompleteDos error when reading DOSCAR.LCFO.lobster files
naik-aakash Sep 30, 2024
998840f
add test files
naik-aakash Oct 1, 2024
4db7983
update grosspop tests
naik-aakash Oct 1, 2024
aef3f76
update charge, doscar & gropsspop parser
naik-aakash Oct 1, 2024
6e34a44
add BWDF and polarization test
naik-aakash Oct 1, 2024
8786b1c
minor improvments
naik-aakash Oct 1, 2024
aef5a1d
replace special character from Polarization parser
naik-aakash Oct 1, 2024
12dbcea
rename test files, update icohplist & polarization parser
naik-aakash Oct 1, 2024
1ece1a7
try adding encoding to parser
naik-aakash Oct 1, 2024
1af28e9
add test files, update icohplist parser tests
naik-aakash Oct 2, 2024
aa3f1ce
add tests for doscar.lcfo reading
naik-aakash Oct 2, 2024
1840cb5
gzipped test files and added pending tests
naik-aakash Oct 2, 2024
bc12c29
use path for filename
naik-aakash Oct 2, 2024
2a6efa9
use path for filename
naik-aakash Oct 2, 2024
c79df30
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Oct 2, 2024
8720fdc
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Oct 6, 2024
d76a234
address review comments
naik-aakash Oct 6, 2024
85b9739
fix typo in exception
naik-aakash Oct 6, 2024
3130299
add exeception test
naik-aakash Oct 6, 2024
7fb864a
address review comments > add new arg is_lcfo to the parsers
naik-aakash Oct 6, 2024
181e190
Merge branch 'materialsproject:master' into lobster_parsers_update
naik-aakash Oct 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pymatgen/io/lobster/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from .inputs import Lobsterin
from .outputs import (
Bandoverlaps,
Bwdf,
Charge,
Cohpcar,
Doscar,
Expand All @@ -20,6 +21,7 @@
Lobsterout,
MadelungEnergies,
NciCobiList,
Polarization,
SitePotential,
Wavefunction,
)
9 changes: 9 additions & 0 deletions src/pymatgen/io/lobster/inputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ class Lobsterin(UserDict, MSONable):
"useDecimalPlaces",
"COHPSteps",
"basisRotation",
"gridDensityForPrinting",
"gridBufferForPrinting",
)

# These keywords need an additional string suffix
Expand All @@ -87,10 +89,13 @@ class Lobsterin(UserDict, MSONable):
# The keywords themselves (without suffix) can trigger additional functionalities
_BOOLEAN_KEYWORDS: tuple[str, ...] = (
"saveProjectionToFile",
"skipCar",
"skipdos",
"skipcohp",
"skipcoop",
"skipcobi",
"skipMOFE",
"skipMolecularOrbitals",
"skipMadelungEnergy",
"loadProjectionFromFile",
"printTotalSpilling",
Expand All @@ -103,6 +108,9 @@ class Lobsterin(UserDict, MSONable):
"userecommendedbasisfunctions",
"skipProjection",
"printLmosOnAtoms",
"printMofeAtomWise",
"printMofeMoleculeWise",
"writeAtomicOrbitals",
"writeBasisFunctions",
"writeMatricesToFile",
"noFFTforVisualization",
Expand Down Expand Up @@ -131,6 +139,7 @@ class Lobsterin(UserDict, MSONable):
"createFatband",
"customSTOforAtom",
"cobiBetween",
"printLmosOnAtomswriteAtomicDensities",
)

# Generate {lowered: original} mappings
Expand Down
Loading