Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip another failing Phonopy test in Windows after NumPy bumped to 2 in CI #4224

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Skip another failing Phonopy test in Windows after NumPy bumped to 2 in CI #4224

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
286be51
skip another test
DanielYang59 Dec 12, 2024
51b822f
fix import
DanielYang59 Dec 12, 2024
77c602b
update reason
DanielYang59 Dec 12, 2024
b891244
what? looks like the latest monty doesn't pack reverse readline fix?
DanielYang59 Dec 12, 2024
3af8ad0
Revert "what? looks like the latest monty doesn't pack reverse readli…
DanielYang59 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/io/test_phonopy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@
from numpy.testing import assert_allclose, assert_array_equal
from pytest import approx

from pymatgen.core import Element
from pymatgen.core import Element, Structure
from pymatgen.io.phonopy import (
CompletePhononDos,
PhononBandStructure,
PhononBandStructureSymmLine,
Structure,
get_complete_ph_dos,
get_displaced_structures,
get_gruneisen_ph_bs_symm_line,
Expand Down Expand Up @@ -125,6 +124,10 @@ def test_structure_conversion(self):
assert struct_pmg_round_trip.site_properties["magmom"] == struct_pmg.site_properties["magmom"]


@pytest.mark.skipif(
platform.system() == "Windows" and int(np.__version__[0]) >= 2,
reason="cannot run NP2 on windows, see PR 4224",
)
@pytest.mark.skipif(Phonopy is None, reason="Phonopy not present")
class TestGetDisplacedStructures(PymatgenTest):
def test_get_displaced_structures(self):
Expand Down Expand Up @@ -157,11 +160,11 @@ def test_get_displaced_structures(self):
assert os.path.isfile("test.yaml")


@pytest.mark.skipif(Phonopy is None, reason="Phonopy not present")
@pytest.mark.skipif(
platform.system() == "Windows" and int(np.__version__[0]) >= 2,
reason="See https://github.com/conda-forge/phonopy-feedstock/pull/158#issuecomment-2227506701",
reason="cannot run NP2 on windows, see PR 4224",
)
@pytest.mark.skipif(Phonopy is None, reason="Phonopy not present")
class TestPhonopyFromForceConstants(TestCase):
def setUp(self) -> None:
test_path = Path(TEST_DIR)
Expand Down
Loading