Fix ion formula check in ion_or_solid_comp_object of analysis.pourbaix_diagram
#4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
commented
Dec 23, 2024
DanielYang59
force-pushed
the
fix-4231-ion-formula
branch
from
eb5d78f to
0320010
Compare
DanielYang59
commented
Dec 24, 2024
|
|
||
| ELEMENTS_HO = {Element("H"), Element("O")} |
There was a problem hiding this comment.
This is unlikely breaking, was a public var, but should be a class var 9551b5a
DanielYang59
commented
Dec 24, 2024
| @@ -1075,22 +1131,3 @@ def domain_vertices(self, entry): | |||
| list of vertices | |||
| """ | |||
| return self._pbx._stable_domain_vertices[entry] | |||
|
|
|||
|
|
|||
| def generate_entry_label(entry): | |||
There was a problem hiding this comment.
This should be a helper function for PourbaixPlotter (as per its docstring), also as far as I'm aware, there is no usage outside this class, so I might make it a private staticmethod instead b2d464b
DanielYang59
changed the title
ion_or_solid_comp_object of analysis.pourbaix_diagramion_or_solid_comp_object of analysis.pourbaix_diagram
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ion_or_solid_comp_objectofanalysis.pourbaix_diagram, to fix Mistake in regex string of ion_or_solid_comp_object leads to example string formula "Na[+]" failing #4231