Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails native view tags support #599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sebyx07
Copy link

@sebyx07 sebyx07 commented Jul 22, 2022

@jonasjabari
Copy link
Member

jonasjabari commented Jul 25, 2022

hey @sebyx07! Thanks for the PR! I like the idea! Two things:

  • I would not recommend to put support for third party gems like SimpleForm and Kaminari into the core code of matestack-ui-core. There are too many gems out there deserving to be supported. I would love to see documentation on how to support gems like that within an application trough an easy to use API rather than having it baked into matestack-ui-core
    --> Rails view helper support would be an exception of this as Rails cannot be seen as a third party thing
  • We need some specs covering this feature and some minor docs explaining it

Would you be able to adjust your PR towards my feedback and add specs and docs? You find some documentation about the specs workflow here: https://docs.matestack.io/matestack-ui-vuejs/contribute (that's the one for matestack-ui-vuejs, the one for matestack-ui-core is somehow missing. You can just ignore the yarn/js/vuejs things in this guide, the rest should work for core as well)

Happy to help and discuss further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants