Skip to content

instead of lspace_master #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 19, 2025
Merged

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented May 15, 2025

Motivation for this change

Closes #1506

I wasn't able to rebase, hence the new PR closing the old one. @hoheinzollern @CohenCyril @proux01 @t6s

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.12.0 milestone May 15, 2025
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label May 15, 2025
@affeldt-aist
Copy link
Member Author

The last commit renames the HB structure Lfun to Lfunction. There is no impact
on scripts but lets us write \in Lfun instead of \in lfun as we did so far.
The type remains LfunType (this is similar to the contraction of zmodType for Zmodule).

@affeldt-aist affeldt-aist force-pushed the lspace_master2 branch 2 times, most recently from a7dcd80 to 7a253c7 Compare May 29, 2025 10:40
Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issues about the conjugate should be solved before merging.

Local Open Scope classical_set_scope.
Local Open Scope ereal_scope.

Definition conjugate :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Definition conjugate :=
Definition hoelder_conjugate :=

@affeldt-aist
Copy link
Member Author

CI is green

@affeldt-aist affeldt-aist merged commit c5ea0ab into math-comp:master Jun 19, 2025
34 checks passed
This was referenced Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants