Skip to content

Comments

fix(oauth): naver 로그인 해지 api 요청에 service_provider 파라미터 추가#274

Merged
huhdy32 merged 1 commit intodevelopfrom
fix/oauth
Nov 13, 2025
Merged

fix(oauth): naver 로그인 해지 api 요청에 service_provider 파라미터 추가#274
huhdy32 merged 1 commit intodevelopfrom
fix/oauth

Conversation

@huhdy32
Copy link
Collaborator

@huhdy32 huhdy32 commented Nov 13, 2025

https://developers.naver.com/forum/posts/37512

  • Token Revocation service_provider 필수였음
  • 왜 문서화 안되있음? 네이버 어이없음!
  • 두번째 이미지에 부재!!!!!
스크린샷 2025-11-13 오후 3 10 49 스크린샷 2025-11-13 오후 3 14 26

@huhdy32 huhdy32 self-assigned this Nov 13, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @huhdy32, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 Naver OAuth 토큰 해지 과정에서 발생하던 기능적 문제를 해결합니다. Naver의 토큰 해지 API가 요구하는 필수 service_provider 파라미터가 누락되어 API 호출이 실패하던 것을 수정하여, 사용자가 Naver 로그인 연동을 성공적으로 해지할 수 있도록 합니다. 이는 서비스의 안정성과 사용자 경험을 개선하는 데 기여합니다.

Highlights

  • Naver 토큰 해지 API 수정: Naver 로그인 해지 API 요청 시 service_provider 파라미터가 누락되어 발생하던 문제를 해결했습니다. 이 파라미터는 Naver의 토큰 해지 서비스에 필수적이지만 문서화되어 있지 않았습니다.
  • 필수 파라미터 추가: NaverOAuthClient.java 파일의 revoke 메서드에 service_provider 파라미터를 NAVER 값으로 추가하여 API 요청이 정상적으로 처리되도록 했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

네이버 OAuth 토큰 해지 API 요청에 누락되었던 service_provider 파라미터를 추가하는 수정사항을 잘 확인했습니다. 이로써 네이버 계정 연동 해제가 정상적으로 동작할 것으로 기대됩니다. 코드의 유지보수성을 높이기 위해 한 가지 제안 사항을 리뷰 코멘트로 남겼습니다.

@huhdy32 huhdy32 enabled auto-merge (squash) November 13, 2025 06:14
@huhdy32 huhdy32 merged commit 9380bd9 into develop Nov 13, 2025
1 check passed
@huhdy32 huhdy32 deleted the fix/oauth branch November 13, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant