Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Date object serialization, make json more consistent with JSON.stringify #58

Closed
wants to merge 2 commits into from
Closed

feat: support Date object serialization, make json more consistent with JSON.stringify #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924392d
feat: support Date object serialization
Apr 3, 2020
d4ccf90
fix: output empty object for Set, Map with json: true
Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jsesc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ const isObject = (value) => {
// This is a very simple check, but it’s good enough for what we need.
return toString.call(value) == '[object Object]';
};
const isDate = (value) => {
return toString.call(value) == '[object Date]';
};
const isString = (value) => {
return typeof value == 'string' ||
toString.call(value) == '[object String]';
Expand Down Expand Up @@ -205,6 +208,9 @@ const jsesc = (argument, options) => {
if (useOctNumbers) {
return '0o' + argument.toString(8);
}
} else if (isDate(argument)) {
// Date objects have a toJSON method, which implies json: false here.
return 'new Date(' + jsesc(argument.valueOf(), options) + ')';
} else if (!isObject(argument)) {
if (json) {
// For some values (e.g. `undefined`, `function` objects),
Expand Down
6 changes: 6 additions & 0 deletions src/jsesc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ const isObject = (value) => {
// This is a very simple check, but it’s good enough for what we need.
return toString.call(value) == '[object Object]';
};
const isDate = (value) => {
return toString.call(value) == '[object Date]';
};
const isString = (value) => {
return typeof value == 'string' ||
toString.call(value) == '[object String]';
Expand Down Expand Up @@ -205,6 +208,9 @@ const jsesc = (argument, options) => {
if (useOctNumbers) {
return '0o' + argument.toString(8);
}
} else if (isDate(argument)) {
// Date objects have a toJSON method, which implies json: false here.
return 'new Date(' + jsesc(argument.valueOf(), options) + ')';
mathiasbynens marked this conversation as resolved.
Show resolved Hide resolved
} else if (!isObject(argument)) {
if (json) {
// For some values (e.g. `undefined`, `function` objects),
Expand Down
25 changes: 25 additions & 0 deletions tests/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,31 @@ describe('common usage', function() {
'Buffer.from([\n\t19,\n\t55,\n\t66\n])',
'Stringifying a Buffer with `compact: false`'
);
// Date
assert.equal(
jsesc(
new Date('2020-04-03T15:34:00Z')
),
'new Date(1585928040000)'
);
assert.equal(
jsesc(
new Date('2020-04-03T15:34:00Z'),
{
'numbers': 'hexadecimal'
}
),
'new Date(0x17140AD6E40)'
);
assert.equal(
jsesc(
new Date('2020-04-03T15:34:00Z'),
{
'json': true
}
),
'"2020-04-03T15:34:00.000Z"'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on how we want to deal with #57, Is this what you'd expect when passing a Date/Map/Set while using json: true? Or would you want to throw an exception instead?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way this would need to be documented in the README under the json option.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the behavior of toJSON. I'd like to add an additional flag in a subsequent PR (or, I suppose, in this PR) to let the user override that behavior independent of the JSON mode.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could include an interpret option that accepts values like expect-json, coerce-json, and javascript to switch between the options. expect-json would throw on non-JSON-supported values; coerce-json would invoke toJSON and delegate to JSON.stringify's behavior in other cases; javascript would do its best to serialize all (non-circular) values for use in a js context.

I don't need expect-json for my own work, but coerce-json would be extremely useful. I've also been wondering if we could introduce a replacer-type option for both transforming and extending the supported values - e.g. we need strict coerce-json semantics, but also want to support the undefined value. If you're amenable to that, I'll see what that would take.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I've used jsesc is always very controlled, in that: if there's a Date object, a Map, a Set, or a BigInt somewhere in the input, and I am requesting JSON output via json: true, that's probably a mistake. I've only used jsesc in cases where I want JSON.parse(output) to produce an equivalent object again.

So I defer to you on this. If you have a use case for it, that's great!

);
// JSON
assert.equal(
jsesc('foo\x00bar\xFF\uFFFDbaz', {
Expand Down