a way to fetch data when building from form_params #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the best way of dealing with it.
The problem of the previous code is, that there was no way of matching existing data to form_params for
polymorphic_embeds_many.The reason is simple. form params are typically string keys and are passed as such to the changeset.
The previous code only did look at
:idwhen trying to find existing data to apply changes to.Now the
castmethod also checks forparams[persistent_id]which is automatically added bypolymorphic_inputs_forThis way data that isn't send forth and back by the form will persist in changesets.