939 accessibility options #943
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: dockview accessibility
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 182a2ae:
|
mathuo
force-pushed
the
939-accessibility-options
branch
2 times, most recently
from
fb055e5 to
5c5ba11
Compare
mathuo
force-pushed
the
939-accessibility-options
branch
from
5c5ba11 to
182a2ae
Compare
iammola
reviewed
Sep 2, 2025
Comment on lines
+102
to
+104
| this.element.role = 'tablist'; | ||
| this.element.ariaLabel = | ||
| 'Use the Left Arrow to select the previous tab, Right Arrow for the next tab, Home for the first tab, and End for the last tab. Press Enter to select the focused tab.'; |
Contributor
There was a problem hiding this comment.
Hey @mathuo,
These attributes can only be set below lines
dockview/packages/dockview-core/src/dockview/components/titlebar/tabs.ts
Lines 108 to 112 in 182a2ae
The _element property is undefined at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.