Staging #29
Open
Staging #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
EUdler
commented
Feb 6, 2025
EUdler
commented
- Routine changes for R2025a
- Fixed image source file for each release readme
- Changes for when using an existing vNet
…tion-server-on-azure into staging
* Routine updates for new release, * Fixed source for graphic in each release readme * New information for when using an existing vNet
|
Looks good to me! |
mahimab1
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Do we need to add somewhere private end point description to access the storage account? Like in case when usePublicIPAddress is set to "No", then the storage account is only accessible via private end point. The user can create a jumper VM in the same VNet -> subnet to access it. It is more likely an Azure workflow not anything specific to us and I guess the user will know if they see private end point with storage account but I guess it might be important for the user to know before hand so that they don't have to navigate and understand. @mwshriya @EUdler Let me know your opinion
Added information about private endpoint as Mahima suggested
mahimab1
approved these changes
Feb 12, 2025
In the "Allow Connections From" field, I added an example of the format for listing multiple addresses
Made changes based on Shriya's feedback -Added to "Use Public IP Addresses" field to add info about storage account -Added information about NLM and function execution to "Allow Connections From" field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.