Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing support to ElevationGained aggregation #129

Merged
merged 1 commit into from
Aug 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,19 @@ class ReactElevationGainedRecord : ReactHealthRecordImpl<ElevationGainedRecord>
}

override fun getAggregateRequest(record: ReadableMap): AggregateRequest {
throw AggregationNotSupported()
return AggregateRequest(
metrics = setOf(
ElevationGainedRecord.ELEVATION_GAINED_TOTAL
),
timeRangeFilter = record.getTimeRangeFilter("timeRangeFilter"),
dataOriginFilter = convertJsToDataOriginSet(record.getArray("dataOriginFilter"))
)
}

override fun parseAggregationResult(record: AggregationResult): WritableNativeMap {
throw AggregationNotSupported()
return WritableNativeMap().apply {
putMap("ELEVATION_GAINED_TOTAL", lengthToJsMap(record[ElevationGainedRecord.ELEVATION_GAINED_TOTAL]))
putArray("dataOrigins", convertDataOriginsToJsArray(record.dataOrigins))
}
}
}
8 changes: 7 additions & 1 deletion src/types/aggregate.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ interface PowerAggregateResult extends BaseAggregate {
POWER_MAX: PowerResult;
}

interface ElevationGainedAggregateResult extends BaseAggregate {
recordType: 'ElevationGained';
ELEVATION_GAINED_TOTAL: LengthResult;
}

export type AggregateRecordResult =
| ActiveCaloriesBurnedAggregateResult
| BasalMetabolicRateAggregateResult
Expand All @@ -195,7 +200,8 @@ export type AggregateRecordResult =
| WheelchairPushesAggregateResult
| StepsCadenceAggregateResult
| TotalCaloriesBurnedAggregateResult
| PowerAggregateResult;
| PowerAggregateResult
| ElevationGainedAggregateResult;

export type AggregateResultRecordType = AggregateRecordResult['recordType'];

Expand Down
Loading