-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds a new method for requesting exercise permissions #167
Open
ugurakin1
wants to merge
7
commits into
matinzd:main
Choose a base branch
from
runna-app:feat/exercise-route-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1aea823
feat: adds a new method for requesting exercise permissions
ugurakin1 967eefc
feat: changes request permission interface to include a flag for rout…
ugurakin1 a4346d1
chore: reverted code formatting
ugurakin1 a91e223
chore: merge main into feature branch
ugurakin1 e584c62
chore: remove merge cursor
ugurakin1 fd1cfd5
chore: reverted more formatting changes
ugurakin1 e529d22
chore: minor diff clean up
ugurakin1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,12 +34,21 @@ class HealthConnectModule internal constructor(context: ReactApplicationContext) | |
@ReactMethod | ||
override fun requestPermission( | ||
permissions: ReadableArray, | ||
providerPackageName: String, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wasn't used so replaced it. |
||
includeRoute: Boolean?, | ||
promise: Promise | ||
) { | ||
return manager.requestPermission(permissions, providerPackageName, promise) | ||
return manager.requestPermission(permissions, includeRoute, promise) | ||
} | ||
|
||
@ReactMethod | ||
override fun requestExerciseRoute( | ||
recordId: String, | ||
promise: Promise | ||
) { | ||
return manager.requestExerciseRoute(recordId, promise) | ||
} | ||
|
||
|
||
@ReactMethod | ||
override fun getGrantedPermissions(promise: Promise) { | ||
return manager.getGrantedPermissions(promise) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting some flaky results with exercises, everything returns permissions denied as in exerciseRoute is null and as is there is no way to know for certain if that's because there is no data or something is wrong with my patch/permissions etc. Maybe we should fetch the exercise record here and switch on
ExerciseRouteResult
to determine whether to request permission or reject with "NoDataException". Could go hand in hand with this.