-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aggregateGroupByDuration API #171
base: main
Are you sure you want to change the base?
Conversation
@matinzd Hey! Is there any chance you could merge this soon? |
period: 'DAYS' | 'WEEKS' | 'MONTHS' | 'YEARS'; | ||
duration: number; | ||
length: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause a breaking change. Can you update the related documentations as well as readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will handle it soon 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ...
I can arrange that. Let's merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine! I will do a manual testing soon and will merge it.
Can you update the related documentation pages accordingly and also update README about the breaking change?
Thank you for your contribution 🌸 |
Summary
Following #157, I have made a similar addition for aggregateGroupByDuration.
Difference between
Duration
andPeriod
classes in Java:AGGREGATE SAMPLE GROUP DATA BY DURATION button: Added the "AGGREGATE SAMPLE GROUP DATA BY DURATION" button, as shown below, to test the
aggregateGroupByDuration API
.Log after AGGREGATE SAMPLE GROUP DATA BY DURATION button is pressed