Scheduled Reports | X o'clock UTC >> XX:00 UTC

[chippison]

Description

DEV-17057

We want to change the labeling in our Scheduled report for when to send the report.

fixes #21118

Checklist

• [NA] I have understood, reviewed, and tested all AI outputs before use
• [NA] All AI instructions respect security, IP, and privacy rules

Review

• Functional review done
• Potential edge cases thought about (behaviour of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• New documentation added or existing documentation updated

[sgiehl]

Issues identified by Codex

[sgiehl]

Incorrect UTC time formatting for half-hour offsets. reportHourUtc floors the hour and always formats :00, so 10.5 becomes 10:00 instead of 10:30. This is wrong for time zones like Asia/Kolkata.

[chippison]

Hi @sgiehl ,
I saw this when reviewing from codex as well, but when I checked with what was happening in 5.x-dev, it was also not showing the minutes and just always the hours.

Like:

Choose 7:30 -> 22 o'clock

We also have code in reportHours that changes our selectbox to add '.5' to our selections so that we also ensure we choose something with 'xx:30' when we are in timezone with 'UTC+30'

if ((this.timeZoneDifferenceInHours * 2) % 2 !== 0) {
  hours.push({
    key: `${i}.5`,
    value: `${paddedHour}:30`,
  });
} else {
  hours.push({
    key: `${i}`,
    value: `${paddedHour}:00`,
  });
}

Meaning, if we have a timezone with UTC+30, we are forced to select '00:30, 01:30, etc' instead of '00:00, 01:00'

I thought that because of these, this was what it was intending to do and we always 'try' to send the report at the hour and not in 30 mins increment.

Caveat:
This will not work for UTC+45 timezones though, but after checking its only Nepal and Chatham Islands that seem to use this timezone, but let me know if we want to make changes so that we cover this edge case

[sgiehl]

UI test only checks visibility, not correctness of the UTC text. It won’t catch the half‑hour formatting bug.

[chippison]

Added test for actual time when the timezone value is not UTC. If it is UTC, we do not check the time value since we just hide the help text anyway