-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Make changes to options when exporting in CSV and TSV #24045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chippison
wants to merge
13
commits into
5.x-dev
Choose a base branch
from
dev-14698
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chippison
commented
Feb 3, 2026
…hen format is csv or tsv
…hat are not CSV and TSV
…e expand option to be true when it is other formats
… our new logic. we also don't want to change default behaviour if the data does not have a subtable
…nd subtable option w/o forcing the user to change selection if it has added some selections
This is helpful for exporting RowEvolution data.
…t flaky-ness due to waitForTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DEV-14698
When exporting a report in CSV and TSV, we would want to:
For other formats ('JSON', 'RSS', 'XML', 'HTML')
NOTE:
CSV/TSV exports do not support expanded subtables, so we always export the flattened table for these formats. This changes the output from top‑level referrers to flattened subtable rows and removes goal‑specific columns that aren’t present in the flattened export. The new fixtures (tests/UI/expected-screenshots/ReportExporting_Referrers.getWebsites_exported.csv.txt and tests/UI/expected-screenshots/ReportExporting_Referrers.getWebsites_exported.tsv.txt) reflect the intended CSV/TSV behavior.
Acceptance Criteria
Should only happen when a datatable to be exported has subtables. We don't change behaviour when table has no subtable
Checklist
Review