Clarify 'Keep Page URL fragments' setting description #24060
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added (#) to the setting title to make it immediately clear what 'fragments' refers to - Added inline help text explaining URL fragments with an example, noting usefulness for single-page applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22791
This PR clarifies the "Keep Page URL fragments when tracking Page URLs" option in Measurable Settings by:
(#)to the setting title — making it immediately obvious that "fragments" refers to the hash (#) portion of URLsexample.com/page#section) and noting this is useful for single-page applications or anchor-based navigationBefore
The setting title was: "Keep Page URL fragments when tracking Page URLs" with no additional context.
After
The title now reads: "Keep Page URL fragments (#) when tracking Page URLs" with an inline help tooltip explaining what URL fragments are.
Changes
plugins/SitesManager/lang/en.json— updated title string, added newKeepURLFragmentsInlineHelptranslation keyplugins/WebsiteMeasurable/MeasurableSettings.php— addedinlineHelpto the keep URL fragments field