Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ChatGPT "params" #101

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Add missing ChatGPT "params" #101

merged 1 commit into from
Mar 6, 2024

Conversation

mneudert
Copy link
Member

@mneudert mneudert commented Mar 6, 2024

The new entry for ChatGPT provided by #100 has missing params and results in a notice+warning when a ChatGPT referrer is parsed:

PHP Notice: Undefined index: params in /srv/matomo/plugins/Referrers/SearchEngine.php on line 231
PHP Warning: Invalid argument supplied for foreach() in /srv/matomo/plugins/Referrers/SearchEngine.php on line 283

Eventually, the referrer parsing should handle those problems more gracefully. A CI job to verify all entries have a consistent structure could also help here. But in the meantime, this should keep the logs happy.

@michalkleiner michalkleiner merged commit d3bb2a6 into master Mar 6, 2024
1 check passed
@michalkleiner michalkleiner deleted the chatgpt-params branch March 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants