Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HOWTO.md #503

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update HOWTO.md #503

wants to merge 1 commit into from

Conversation

AllMightLegend
Copy link

#433 Issue
Replaced "node:querystring" with URLSearchParams API

@AllMightLegend
Update HOWTO.md
f85c2b2 
matrix-org#433 Issue
Replaced "node:querystring" with URLSearchParams API
@AllMightLegend AllMightLegend requested a review from a team as a code owner August 9, 2024 23:14
tadzik
tadzik requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look correct. You're passing the http module as a query string to parse, and then using a boolean method to parse.

This should look more like const params= new URLSearchParams(body), and then params.get('user_name') etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllMightLegend @tadzik