Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

OAuth 2.0 sessions list and get admin APIs #3031

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

sandhose
Copy link
Member

This can be reviewed commit by commit.

  • admin: model definition for the OAuth 2.0 sessions
  • admin: setup base for oauth2 sessions endpoints
  • admin: list OAuth 2.0 sessions API
  • admin: get OAuth 2.0 session API

@sandhose sandhose added the A-Admin-API Related to the admin API label Jul 30, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab16d25
Status: ✅  Deploy successful!
Preview URL: https://d34bfd32.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-admin-api-sessions.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose force-pushed the quenting/admin-api/sessions branch from 59c2505 to fec4c34 Compare August 1, 2024 14:31
@sandhose sandhose changed the base branch from quenting/admin-api/temp-merge-base to main August 1, 2024 14:31
@sandhose sandhose mentioned this pull request Aug 2, 2024
13 tasks
@sandhose sandhose force-pushed the quenting/admin-api/sessions branch 2 times, most recently from 26adc63 to 85a82fb Compare August 6, 2024 15:59
@sandhose sandhose marked this pull request as ready for review August 6, 2024 15:59
@sandhose sandhose force-pushed the quenting/admin-api/sessions branch from 85a82fb to ab16d25 Compare August 7, 2024 13:38
@sandhose sandhose requested a review from reivilibre August 7, 2024 13:38
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine :)

}
],
"links": {
"self": "/api/admin/v1/oauth2-sessions?page[first]=10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess too late to ask this now, but what's the idea behind this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the JSON API spec adds self links wherever it can, so that you get canonical URLs of even nested stuff

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API Related to the admin API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants